Support wide angle camera #744
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
…format into wide_angle_camera_12
Codecov Report
@@ Coverage Diff @@
## sdf12 #744 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 76 76
Lines 11785 11790 +5
=======================================
+ Hits 10444 10449 +5
Misses 1341 1341
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]>
|
added integration test in 2800f2c |
src/Sensor.cc
Outdated
| @@ -64,7 +64,8 @@ const std::vector<std::string> sensorTypeStrs = | |||
| "navsat", | |||
| "segmentation_camera", | |||
| "boundingbox_camera", | |||
| "custom" | |||
| "custom", | |||
| "wideanglecamera" | |||
There was a problem hiding this comment.
We should document this string here: https://github.com/ignitionrobotics/sdformat/blob/f2a286cbf89aca7daa722a70a357e0de32224372/sdf/1.9/sensor.sdf#L10-L36
Most other cameras are using camel_case (at least partially), can we do it here too? i.e. wideangle_camera or wide_angle_camera, or all of them to be safe?
There was a problem hiding this comment.
the existing convention with gazebo classic is wideanglecamera. I think we can choose to add alternates, but I would keep wideanglecamera for backwards compatibility
There was a problem hiding this comment.
changed wideanglecamera to wide_angle_camera here. Also updated the Load function to check for both wide_angle_came and wideanglecamera when loading the sdf for backward compatibility.
8aacb98
Signed-off-by: Ian Chen <[email protected]>
…format into wide_angle_camera_12
|
Is there any possibility to add this feature in |
|
the PRs to add wide angle camera support in gz-rendering (gazebosim/gz-rendering#490 and gazebosim/gz-rendering#733) include ABI breaking changes so I think it'll be difficult to backport all wide angle camera related changes to Fortress. |
🎉 New feature
Summary
Updates the Sensor DOM to support parsing wide angle cameras.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge