Fixed ROS subscriber test in ros_ign_bridge #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Lew <[email protected]>
Signed-off-by: William Lew <[email protected]>
|
Wow thanks for catching this, amazing that it's been like that from the beginning 😮 There are some test failures still. |
WilliamLewww
force-pushed
the
wlew/fix_ros_subscriber_test
branch
2 times, most recently
from
fe8c972 to
747f9e9
Compare
Signed-off-by: William Lew <[email protected]>
WilliamLewww
force-pushed
the
wlew/fix_ros_subscriber_test
branch
from
747f9e9 to
fa86abe
Compare
Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Fixed ROS subscriber test in ros_ign_bridge
Summary
test_ros_subscriberwas using theign_subscriber.cppsource file causing the incorrect tests to be built. This pull request fixestest_ros_subscriber's build files as well as some errors insideros_subscriber.cpp.https://github.com/ignitionrobotics/ros_ign/blob/5d9cfef3d58948a77b962d231e281c88ea88e188/ros_ign_bridge/CMakeLists.txt#L163
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge