Add note about mass in auto inertial proposal #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
9 tasks
Signed-off-by: Ian Chen <[email protected]>
scpeters
approved these changes
Dec 11, 2024
auto_inertial_params/proposal.md
Outdated
| added in the spec to allow users to specify the density values on a link level instead of | ||
| specifying the same values for each collision. Note that if `//link/inertial/mass` is also | ||
| specified, the link's inertial parameters will be scaled to match the input mass while | ||
| respecting the ratio of collision density values. |
There was a problem hiding this comment.
this looks good to me; I think we just need to note which versions of libsdformat support this change (presumably it will be in 15.2 and 14.7)
There was a problem hiding this comment.
added libSdformat versions to the note. d405d34
Signed-off-by: Ian Chen <[email protected]>
scpeters
approved these changes
Dec 11, 2024
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
See diff without whitespace:
https://github.com/gazebosim/sdf_tutorials/pull/100/files?w=1
Summary
Added a note to mention how inertial params are computed if mass is specified.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.