ign -> gz Namespace Migration : sdformat #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapulina
added
the
needs upstream release
methylDragon
force-pushed
the
namespace_migration
branch
6 times, most recently
from
83da7ab to
2e63c36
Compare
8 tasks
methylDragon
force-pushed
the
namespace_migration
branch
from
373dfdd to
47305f3
Compare
chapulina
suggested changes
May 24, 2022
methylDragon
force-pushed
the
namespace_migration
branch
from
47305f3 to
8920295
Compare
chapulina
suggested changes
May 24, 2022
methylDragon
force-pushed
the
namespace_migration
branch
from
ff7d507 to
731ee8b
Compare
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
methylDragon
force-pushed
the
namespace_migration
branch
from
731ee8b to
422058f
Compare
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 27 27
=======================================
Hits 18 18
Misses 9 9 Continue to review full report at Codecov.
|
chapulina
removed
the
needs upstream release
scpeters
reviewed
May 31, 2022
| @@ -65,12 +65,12 @@ namespace sdf | |||
| public: sdf::ElementPtr Element() const; | |||
|
|
|||
| /// \brief Get the Ignition Math representation of this Cylinder. | |||
| /// \return A const reference to an ignition::math::Cylinderd object. | |||
| public: const ignition::math::Cylinderd &Shape() const; | |||
| /// \return A const reference to an gz::math::Sphered object. | |||
There was a problem hiding this comment.
nit: revert the Sphered change back to Cylinderd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gazebo-tooling/release-tools#711