Don't include the gz/math.hh header from library code #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Using overly-broad include statements leads to slower builds and bloated object code. Signed-off-by: Jeremy Nimmer <[email protected]>
jwnimmer-tri
force-pushed
the
gz-math-specific-includes
branch
from
bebcb4f to
cadbd0f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 83.64% 83.64%
=======================================
Files 146 146
Lines 18255 18255
=======================================
Hits 15269 15269
Misses 2986 2986
Continue to review full report at Codecov.
|
azeey
approved these changes
Jun 7, 2022
azeey
pushed a commit
to azeey/sdformat
that referenced
this pull request
Jun 7, 2022
Using overly-broad include statements leads to slower builds and bloated object code. Signed-off-by: Jeremy Nimmer <[email protected]>
azeey
added a commit
to azeey/gz-sim
that referenced
this pull request
Jun 8, 2022
Some libsdformat headers used to include `gz/math.hh`, but that is no longer the case since gazebosim/sdformat#1043. As a result, gz-sim has to be updated to include the necessary headers. Signed-off-by: Addisu Z. Taddese <[email protected]>
8 tasks
chapulina
pushed a commit
to gazebosim/gz-sim
that referenced
this pull request
Jun 8, 2022
Some libsdformat headers used to include `gz/math.hh`, but that is no longer the case since gazebosim/sdformat#1043. As a result, gz-sim has to be updated to include the necessary headers. Signed-off-by: Addisu Z. Taddese <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Don't include the gz/math.hh header from library code. Using overly-broad include statements leads to slower builds and bloated object code. This commit swaps it out the
gz/math.hh"everything" header for more targets files, instead.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.