Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface::ToElement: add //friction/ode/mu #1049

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Conversation

scpeters
Copy link
Member

🎉 New feature

Follow-up to #1036

Summary

The mjcf_to_sdformat converter in gz-mujoco constructs DOME objects programmatically and then uses Root::ToElement serialize to an XML file. Currently the Surface class adds elements for //contact/collide_bitmask in Surface::ToElement, and this pull request adds //friction/ode/mu as a minimal approach to supporting friction parameters.

Test it

Run UNIT_Collision_TEST

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from azeey as a code owner June 15, 2022 05:37
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 15, 2022
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1049 (6f3cd14) into main (e91782b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1049   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files         148      148           
  Lines       18393    18396    +3     
=======================================
+ Hits        15353    15356    +3     
  Misses       3040     3040           
Impacted Files Coverage Δ
src/Surface.cc 87.96% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e91782b...6f3cd14. Read the comment docs.

@scpeters scpeters merged commit 8df2133 into main Jun 21, 2022
@scpeters scpeters deleted the scpeters/fricton_to_element branch June 21, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants