Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest to generate junit xml files for python tests #1063

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Jun 29, 2022

🦟 Bug fix

Summary

Python unit tests currently don't generate junit xml files for consumption by Jenkins. This results in Jenkins indicating that there are no failing tests when python tests are failing. couldn't find a way to generate these files using the builtin unittest python library, so I have added a dependency on pytest. If pytest is not available, a CMake warning is emitted.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from scpeters as a code owner June 29, 2022 03:39
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1063 (6612e0b) into main (d3fde45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   83.39%   83.39%           
=======================================
  Files         151      151           
  Lines       18490    18490           
=======================================
  Hits        15419    15419           
  Misses       3071     3071           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3fde45...6612e0b. Read the comment docs.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, and I think we could follow up by adding pytest to the following line to enable junit output for homebrew builds

@ahcorde ahcorde merged commit ea6ace6 into gazebosim:main Jun 29, 2022
@azeey azeey deleted the use_pytest branch June 29, 2022 15:41
@azeey
Copy link
Collaborator Author

azeey commented Jun 29, 2022

looks good, and I think we could follow up by adding pytest to the following line to enable junit output for homebrew builds

Thanks for pointing me to that! I wasn't sure what to do after I saw that it wasn't possible to install pytest from homebrew.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants