Replace custom SDF_* macros with GZ_* #1067
Conversation
Replace custom implementation of SDF_DEPRECATED and SDF_SUPPRESS_DEPRECATED_* macros with the GZ_* macro counterparts. Signed-off-by: Steve Peters <[email protected]>
|
windows CI doesn't like this |
Codecov Report
@@ Coverage Diff @@
## main #1067 +/- ##
=======================================
Coverage 83.14% 83.14%
=======================================
Files 154 154
Lines 18724 18724
=======================================
Hits 15568 15568
Misses 3156 3156
Continue to review full report at Codecov.
|
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
scpeters
changed the title
Signed-off-by: Steve Peters <[email protected]>
| @@ -169,57 +170,57 @@ class SDFORMAT_VISIBLE NestedInclude | |||
| /// not end with a file extension (it will not end with an extension if it | |||
| /// refers to a model package). | |||
| /// \deprecated Use NestedInclude::Uri() instead | |||
| public: std::string uri SDF_DEPRECATED(12); | |||
| public: GZ_DEPRECATED(12) std::string uri; | |||
There was a problem hiding this comment.
oh, these were actually deprecated in fortress; I suppose they can be removed here. Do you mind if I do that in a separate pull request?
There was a problem hiding this comment.
Oh yeah I didn't pay attention to the diff. SGTM
🎉 New feature
Reduce duplicate macro definitions
Summary
Replace custom implementation of
SDF_DEPRECATEDandSDF_SUPPRESS_DEPRECATED_*macros with theGZ_*macro counterparts.Test it
Remove the
SDF_SUPPRESS_*lines in InterfaceElements.cc and compile to confirm thatSDF_DEPRECATEDmacro still works.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.