Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDF::SetRoot and deprecate non-const SDF::Root #1070

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 7, 2022

🎉 New feature

Deprecate the setter API that doesn't start with Set

Summary

I just noticed this API that should be called SetRoot. I've updated it here, and I don't see it used in other Garden packages, so I don't think this will introduce deprecation warnings.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from azeey as a code owner July 7, 2022 23:30
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 7, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #1070 (efba699) into main (77478ed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files         154      154           
  Lines       18682    18685    +3     
=======================================
+ Hits        15527    15530    +3     
  Misses       3155     3155           
Impacted Files Coverage Δ
src/SDF.cc 94.04% <100.00%> (+0.10%) ⬆️
src/parser.cc 87.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77478ed...efba699. Read the comment docs.

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/SDF_TEST.cc is failing

Signed-off-by: Steve Peters <[email protected]>
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@scpeters scpeters merged commit 1570833 into main Jul 8, 2022
@scpeters scpeters deleted the scpeters/set_root branch July 8, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants