Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Polyline Python interface #1084

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Added Polyline Python interface #1084

merged 2 commits into from
Jul 23, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 20, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

This PR is part of this meta ticket #931

Summary

Added Polyline Python interface

Test it

from sdformat import Polyline

polyline = Polyline()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested review from azeey and scpeters as code owners July 20, 2022 19:38
@ahcorde ahcorde self-assigned this Jul 20, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 20, 2022
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #1084 (673ec36) into main (b001313) will decrease coverage by 0.03%.
The diff coverage is 59.25%.

@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
- Coverage   83.14%   83.11%   -0.04%     
==========================================
  Files         154      155       +1     
  Lines       18736    18763      +27     
==========================================
+ Hits        15578    15594      +16     
- Misses       3158     3169      +11     
Impacted Files Coverage Δ
python/src/sdf/pyPolyline.cc 57.69% <57.69%> (ø)
python/src/sdf/_gz_sdformat_pybind11.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b001313...673ec36. Read the comment docs.

@chapulina chapulina merged commit e4f63fb into main Jul 23, 2022
@chapulina chapulina deleted the ahcorde/python/polyline branch July 23, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden scripting Scripting interfaces to Ignition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants