Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sky Cubemap methods to Python #1085

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jul 21, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Added Sky Cubemap methods to Python

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Jul 21, 2022
@ahcorde ahcorde requested review from azeey and scpeters as code owners July 21, 2022 09:06
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1085 (c972413) into main (b001313) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head c972413 differs from pull request most recent head 670183e. Consider uploading reports for the commit 670183e to get more accurate results

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
- Coverage   83.14%   83.13%   -0.01%     
==========================================
  Files         154      154              
  Lines       18736    18740       +4     
==========================================
+ Hits        15578    15580       +2     
- Misses       3158     3160       +2     
Impacted Files Coverage Δ
python/src/sdf/pySky.cc 57.44% <50.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b001313...670183e. Read the comment docs.

@chapulina chapulina added the scripting Scripting interfaces to Ignition label Jul 21, 2022
@ahcorde ahcorde merged commit bf95c0e into main Jul 22, 2022
@ahcorde ahcorde deleted the ahcorde/python/sky_cubemap branch July 22, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden scripting Scripting interfaces to Ignition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants