Param::Set: fix truncation of floating-point values #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <[email protected]>
Prevent truncation of floating point digits in Param::Set and Param::GetDefault. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1137 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 125 125
Lines 15834 15834
=======================================
Hits 13777 13777
Misses 2057 2057
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jennuine
reviewed
Sep 9, 2022
9 tasks
Signed-off-by: Ian Chen <[email protected]>
iche033
force-pushed
the
scpeters/param_set_digits
branch
from
60d0070 to
5c9edf8
Compare
|
just amended and signed off the last commit |
@jennuine we have a stable release of sdformat13, so I think we can start merging for 13.1 |
jennuine
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #1136, #103
Summary
As noted in #1136, the
Param::SetAPI currently truncates floating point values, demonstrated by the failing test added in f45d371. In 1107f21, theParamStreamerhelper is used inParam::Setwith maximum digits to prevent truncation. The expected values in a test are adjusted in 9ef6cd7 to expect more precision.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.