-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin: update calls to use sdf::Errors output #1144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## sdf13 #1144 +/- ##
==========================================
+ Coverage 87.42% 87.44% +0.02%
==========================================
Files 126 126
Lines 16314 16341 +27
==========================================
+ Hits 14262 14289 +27
Misses 2052 2052
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
marcoag
force-pushed
the
marcoag/sdf_error_plugin
branch
from
October 3, 2022 10:39
8eb0d1d
to
1420a15
Compare
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
azeey
reviewed
Mar 22, 2023
azeey
reviewed
Mar 22, 2023
Signed-off-by: Marco A. Gutierrez <[email protected]>
azeey
approved these changes
Mar 23, 2023
marcoag
changed the title
Plugin: add sdf::Errors output to API methods
Plugin: update calls to use sdf::Errors output
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco A. Gutierrez [email protected]
🎉 New feature
Work towards #820.
Depends on: #1141.
Summary
Adds missing
Errors
structure parameters in a few methods of the Plugin class.Test it
Using the Plugin class should report all errors through
sdf::Errors
if theerrors
parameter is used, it should print them otherwise.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.