-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Altimeter: update calls to use sdf::Errors output #1160
Conversation
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
5c95715
to
624d7dc
Compare
Codecov Report
@@ Coverage Diff @@
## sdf13 #1160 +/- ##
==========================================
+ Coverage 87.51% 87.53% +0.01%
==========================================
Files 126 126
Lines 16248 16446 +198
==========================================
+ Hits 14220 14396 +176
- Misses 2028 2050 +22
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending branch update, LGTM!
Signed-off-by: Marco A. Gutierrez [email protected]
🎉 New feature
Work towards #820.
Depends on #1151 and: #1141.
Summary
Adds missing
Errors
structure parameters in a few methods of theAltimeter
class.Test it
Using the
Altimeter
class should report all errors throughsdf::Errors
if theerrors
parameter is used, it should print them otherwise.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.