Merge sdf12 ➡️ sdf13 #1177
Merged
Merge sdf12 ➡️ sdf13 #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marqrazz <[email protected]>
Signed-off-by: Brian Chen <[email protected]> Signed-off-by: Steve Peters <[email protected]> Co-authored-by: Steve Peters <[email protected]>
* camera.sdf: fields for projection matrix Signed-off-by: Steve Peters <[email protected]>
Update Changelog and Migration guide. Signed-off-by: Steve Peters <[email protected]>
Merge sdf9 ➡️ sdf12
Signed-off-by: Steve Peters <[email protected]>
The urdf_gazebo_extensions.urdf file had incorrect kinematics with link3 being the child of two different joints. This adds a link4 and replaces joint13 with joint14 connecting link1 and link4. This also fixes some expectations about the implicit_spring_damper tags. * parser_urdf: clean up internal functions by removing unused parameters and making other parameters const. Signed-off-by: Steve Peters <[email protected]>
Merge sdf9 ➡️ sdf12
These directories are added via our cmake macros and don't need to be here. Additionally, one of the patterns was incorrect and adding a relative path to the include dirs. Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1177 +/- ##
==========================================
+ Coverage 87.00% 87.05% +0.04%
==========================================
Files 125 125
Lines 15834 15885 +51
==========================================
+ Hits 13777 13828 +51
Misses 2057 2057
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ahcorde
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
sdf12➡️sdf13Branch comparision: sdf13...sdf12
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)