Make ThrowOrPrintError a free internal function #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove the function without a deprecation cycle. Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1221 +/- ##
=======================================
Coverage 87.20% 87.21%
=======================================
Files 124 124
Lines 16232 16232
=======================================
+ Hits 14155 14156 +1
+ Misses 2077 2076 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
marcoag
approved these changes
Jan 18, 2023
|
Sure makes sense, thanks for the fix! |
Signed-off-by: Addisu Z. Taddese <[email protected]>
|
There's an ABI change, but it's okay since we haven't made a release with #1220. |
mjcarroll
pushed a commit
that referenced
this pull request
Feb 9, 2023
#1220 added sdf::Error::ThrowOrPrintError, but after further thought, I think it would be better if we made it a free function inside the internal namespace as this allows us to remove the function without a deprecation cycle. Since the future goal of libsdformat is to remove exceptions, it is likely that we'd want to remove ThrowOrPrintError in the not too distance future. Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
#1220 added
sdf::Error::ThrowOrPrintError, but after further thought, I think it would be better if we made it a free function inside theinternalnamespace as this allows us to remove the function without a deprecation cycle. Since the future goal of libsdformat is to remove exceptions, it is likely that we'd want to removeThrowOrPrintErrorin the not too distance future.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.