Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: new error enums to Python #1249

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

tejalbarnwal
Copy link
Contributor

@tejalbarnwal tejalbarnwal commented Mar 13, 2023

🎉 New feature

Closes #1102

Summary

Added enum entries for sdf::ErrorCode::ELEMENT_ERROR and sdf::ErrorCode::ROTATION_SNAP_CONFIG_ERROR

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Mar 13, 2023
@scpeters
Copy link
Member

Do you mind signing your commit with git commit --signoff?

@tejalbarnwal tejalbarnwal force-pushed the pr-sdf13-error-enums-python branch from f9d31d8 to f40e54a Compare March 14, 2023 13:15
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1249 (5a0c4ab) into sdf13 (88b87cf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5a0c4ab differs from pull request most recent head bace5fd. Consider uploading reports for the commit bace5fd to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1249   +/-   ##
=======================================
  Coverage   87.51%   87.52%           
=======================================
  Files         126      126           
  Lines       16248    16250    +2     
=======================================
+ Hits        14220    14222    +2     
  Misses       2028     2028           
Impacted Files Coverage Δ
python/src/sdf/pyError.cc 80.82% <100.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@azeey azeey enabled auto-merge (squash) March 16, 2023 15:21
@azeey azeey merged commit 4464fbd into gazebosim:sdf13 Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add new Error enums from #1099 to Python
4 participants