JointAxis: improve code coverage in Load() #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The //axis*/xyz and //axis*/limit elements will always be present, so remove unreachable error checking. Signed-off-by: Steve Peters <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf13 #1267 +/- ##
=======================================
Coverage 87.55% 87.56%
=======================================
Files 126 126
Lines 16476 16472 -4
=======================================
- Hits 14426 14424 -2
+ Misses 2050 2048 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adityapande-1995
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Improve code coverage in JointAxis.cc
Summary
The
//axis*/xyzand//axis*/limitelements are marked as required in the SDFormat spec, so they will always be present. This pull request improves code coverage by removing unreachable error checking that checks if those elements are missing.I noticed part of this change in #1166 and pulled it out to a separate PR.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.