Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new error codes in Python #1280

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented May 12, 2023

🎉 New feature

Summary

New Errors included in Python. Introduced in these PRs:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this May 12, 2023
@ahcorde ahcorde requested review from azeey and scpeters as code owners May 12, 2023 07:53
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1280 (22b5cdc) into sdf13 (38f6435) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 22b5cdc differs from pull request most recent head 063d91f. Consider uploading reports for the commit 063d91f to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1280   +/-   ##
=======================================
  Coverage   87.80%   87.81%           
=======================================
  Files         127      127           
  Lines       16737    16744    +7     
=======================================
+ Hits        14696    14703    +7     
  Misses       2041     2041           
Impacted Files Coverage Δ
python/src/sdf/pyError.cc 82.50% <100.00%> (+1.67%) ⬆️

@scpeters scpeters merged commit e045d1b into sdf13 May 12, 2023
@scpeters scpeters deleted the ahcorde/sdf13/new_error_codes branch May 12, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants