Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor clean up of tests #1289

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Minor clean up of tests #1289

merged 1 commit into from
Jun 7, 2023

Conversation

shameekganguly
Copy link
Contributor

  • Specify std::fstream::in for read-only files
  • Initialize values before accessing them in Element::Get(...)

@shameekganguly
Minor clean up of tests
fc80181 
Signed-off-by: Shameek Ganguly <[email protected]>
@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1289 (4b5e2bd) into sdf13 (3fdc0a1) will not change coverage.
The diff coverage is n/a.

❗ Current head 4b5e2bd differs from pull request most recent head fc80181. Consider uploading reports for the commit fc80181 to get more accurate results

@@           Coverage Diff           @@
##            sdf13    #1289   +/-   ##
=======================================
  Coverage   87.67%   87.67%           
=======================================
  Files         128      128           
  Lines       16814    16814           
=======================================
  Hits        14741    14741           
  Misses       2073     2073

@scpeters scpeters merged commit 4530dba into gazebosim:sdf13 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shameekganguly @ahcorde @scpeters