Correct spelling of Python variable in CMake

[mjcarroll]

Not critical, but does seem to have issues, at least on Windows.

I believe that the problem is that COMMAND is expected to be one argument, so passing the python.exe plus the script name violates that. I'm not sure why this hasn't been an issue before, but it causes all sorts of hilariously bad behavior on Windows (popping open the Microsoft store of VS code rather than trying to run the script).

[codecov]

Codecov Report

Merging #1319 (405e65e) into sdf14 (f6f34e2) will not change coverage.
The diff coverage is n/a.

❗ Current head 405e65e differs from pull request most recent head 2cb94b2. Consider uploading reports for the commit 2cb94b2 to get more accurate results

@@           Coverage Diff           @@
##            sdf14    #1319   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files         134      134           
  Lines       17751    17751           
=======================================
  Hits        15528    15528           
  Misses       2223     2223           

📢 Have feedback on the report? Share it here.

[peci1]

Got hit by this issue, too (in my case, opening GVim.exe :) ).

The resolution is much simpler, though:

sdformat/sdf/1.5/CMakeLists.txt

Line 70 in 881cbb7

COMMAND ${Pyhton3_EXECUTABLE} ${CMAKE_SOURCE_DIR}/tools/xmlschema.py

See, Pyhton ? :-D It's only in the 1.5 SDF CMakeLists, elsewhere it's okay.

@mjcarroll I think you can revert the other changes in your PR as they don't really make sense. CMake docs say ARGS is only for backwards compatibility and is ignored. So my interpretation is that command is always the first thing after COMMAND, while other things are args.

I guess it didn't manifest on the other operating systems as their default is to run .py files with an interpreter instead of an IDE. Although it could have used a wrong interpreter.

[mjcarroll]

Good call, reverted.

I guess it didn't manifest on the other operating systems as their default is to run .py files with an interpreter instead of an IDE.

Yeah, we have a shebang line in the xmlschema.py, so it should just do the right thing on platforms that understand that. Windows is not one of those, unfortunately, so it would have all sorts of silly side effects.

[azeey]

The title of the PR should be renamed though.