In parser config test, use a filename less likely to exist #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file /usr/share/empty is not unique enough to guarantee that it does not exist, and the test seems to require that there be no file or directory with that name. On Fedora, the file /usr/share/empty is present on every single system. Signed-off-by: Scott K Logan <[email protected]>
azeey
approved these changes
Jan 30, 2024
Signed-off-by: Scott K Logan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sdf14 #1362 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 134 134
Lines 17674 17674
=======================================
Hits 16332 16332
Misses 1342 1342 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The file
/usr/share/emptyis not unique enough to guarantee that it does not exist, and the test seems to require that there be no file or directory with that name.On Fedora, the directory
/usr/share/emptyis present on every single system.I'm absolutely open to another more descriptive name for the file, but I chose
should_not_existto start.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.