Update max_convex_hulls description #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
ahcorde
approved these changes
Mar 26, 2024
scpeters
reviewed
Mar 26, 2024
Signed-off-by: Ian Chen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
=======================================
Coverage 92.44% 92.44%
=======================================
Files 134 134
Lines 17812 17812
=======================================
Hits 16467 16467
Misses 1345 1345 ☔ View full report in Codecov by Sentry. |
scpeters
approved these changes
Mar 26, 2024
9 tasks
aagrawal05
pushed a commit
to aagrawal05/sdformat
that referenced
this pull request
Apr 2, 2024
Signed-off-by: Ian Chen <[email protected]>
iche033
added a commit
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Ian Chen <[email protected]>
iche033
added a commit
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Ian Chen <[email protected]>
aagrawal05
pushed a commit
to aagrawal05/sdformat
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Ian Chen <[email protected]>
aagrawal05
pushed a commit
to aagrawal05/sdformat
that referenced
this pull request
Aug 16, 2024
Signed-off-by: Ian Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Update
<max_convex_hulls>description based on the recommendation in gazebosim/gz-physics#606 (review).This parameter now determines the max number of submeshes that will be in the final decomposed mesh.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.