Update default camera instrinsics skew to 0, which matches spec #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shameek Ganguly <[email protected]>
Signed-off-by: Shameek Ganguly <[email protected]>
ahcorde
approved these changes
May 24, 2024
iche033
approved these changes
May 28, 2024
|
Is this change worth announcing on discourse? It could be a breaking change for some folks, but I don't have a sense of how many people will be affected. |
|
I think it's a bugfix that we can mention the change in Migration guide? I imagine most people will be setting skew to 0. |
|
Okay. Adding to the migration guide sounds good. @shameekganguly/@iche033 mind doing that now so we don't forget next time we make a release? |
|
yep I'll take care of it |
8 tasks
8 tasks
aagrawal05
pushed a commit
to aagrawal05/sdformat
that referenced
this pull request
Aug 16, 2024
…bosim#1423) Signed-off-by: Shameek Ganguly <[email protected]>
aagrawal05
pushed a commit
to aagrawal05/sdformat
that referenced
this pull request
Aug 16, 2024
…bosim#1423) Signed-off-by: Shameek Ganguly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Default camera lens intrinsics skew is 0 in the camera sdf spec: https://github.com/gazebosim/sdformat/blob/sdf14/sdf/1.11/camera.sdf
But the default value in
sdf::Cameraclass was set to 1. I've fixed this value to match the spec in this PR and updated the associated tests.Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.