Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations: tock #1519

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Remove deprecations: tock #1519

merged 3 commits into from
Dec 19, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Dec 15, 2024

🦟 Bug fix

Perform the tock of the tick-tock cycle and remove / move deprecated code.

The <optical_frame_id> isn't removed from the spec yet. It'll happen when we create the 1.13 version eventually.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <[email protected]>
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Dec 15, 2024
@caguero caguero changed the base branch from sdf15 to main December 15, 2024 17:06
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero marked this pull request as ready for review December 19, 2024 21:56
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caguero caguero merged commit 30d4a5f into main Dec 19, 2024
15 checks passed
@caguero caguero deleted the caguero/16_tock branch December 19, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants