Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 ➡️ 11 #624

Merged
merged 8 commits into from
Jul 14, 2021
Merged

10 ➡️ 11 #624

merged 8 commits into from
Jul 14, 2021

Conversation

jennuine
Copy link
Collaborator

➡️ Forward port

Port sdf10 to sdf11

Branch comparison: sdf11...sdf10

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

iche033 and others added 8 commits June 23, 2021 10:18
* check for <experimental:params> & test

Signed-off-by: Jenn Nguyen <[email protected]>

* defined xml namespace

Signed-off-by: Jenn Nguyen <[email protected]>

* Param passing prototype: Retrieve specified element (#427)

* retrieve element by identifier under <experimental:params>

Signed-off-by: Jenn Nguyen <[email protected]>

* Moved updateParams before addNestedModel (#464)

* retrieve element for add action & added tests

Signed-off-by: Jenn Nguyen <[email protected]>

* replaced name with element_id

Signed-off-by: Jenn Nguyen <[email protected]>

* moved updateParams before addNestedModel

Signed-off-by: Jenn Nguyen <[email protected]>

* found chars using rfind

Signed-off-by: Jenn Nguyen <[email protected]>

* added error when element_id missing name after ::

Signed-off-by: Jenn Nguyen <[email protected]>

* updated find w/ startIdx

Signed-off-by: Jenn Nguyen <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>

* Param passing prototype: Add action (#546)

* tinyxml2 to string helper

Signed-off-by: Jenn Nguyen <[email protected]>

* add action

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed codecheck errors

Signed-off-by: Jenn Nguyen <[email protected]>

* changed parser_private functions to nonstatic

Signed-off-by: Jenn Nguyen <[email protected]>

* removed specification check

Signed-off-by: Jenn Nguyen <[email protected]>

* add action requires 'name' attribute in spec

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed nested include test

Signed-off-by: Jenn Nguyen <[email protected]>

* removed unused param

Signed-off-by: Jenn Nguyen <[email protected]>

* check name attr nonempty

Signed-off-by: Jenn Nguyen <[email protected]>

* storing attribute to variable

Signed-off-by: Jenn Nguyen <[email protected]>

* Param passing prototype: Remove action (#563)

* tinyxml2 to string helper

Signed-off-by: Jenn Nguyen <[email protected]>

* add action

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed codecheck errors

Signed-off-by: Jenn Nguyen <[email protected]>

* changed parser_private functions to nonstatic

Signed-off-by: Jenn Nguyen <[email protected]>

* removed specification check

Signed-off-by: Jenn Nguyen <[email protected]>

* remove action

Signed-off-by: Jenn Nguyen <[email protected]>

* add action requires 'name' attribute in spec

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed nested include test

Signed-off-by: Jenn Nguyen <[email protected]>

* removed unused param

Signed-off-by: Jenn Nguyen <[email protected]>

* check name attr nonempty

Signed-off-by: Jenn Nguyen <[email protected]>

* Param passing prototype: Replace action (#566)

* tinyxml2 to string helper

Signed-off-by: Jenn Nguyen <[email protected]>

* add action

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed codecheck errors

Signed-off-by: Jenn Nguyen <[email protected]>

* changed parser_private functions to nonstatic

Signed-off-by: Jenn Nguyen <[email protected]>

* removed specification check

Signed-off-by: Jenn Nguyen <[email protected]>

* remove action

Signed-off-by: Jenn Nguyen <[email protected]>

* add action requires 'name' attribute in spec

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed nested include test

Signed-off-by: Jenn Nguyen <[email protected]>

* removed unused param

Signed-off-by: Jenn Nguyen <[email protected]>

* check name attr nonempty

Signed-off-by: Jenn Nguyen <[email protected]>

* replace action

Signed-off-by: Jenn Nguyen <[email protected]>

* renamed init element description function

Signed-off-by: Jenn Nguyen <[email protected]>

* added ParamPassing namespace

Signed-off-by: Jenn Nguyen <[email protected]>

* updated add for plugins

Signed-off-by: Jenn Nguyen <[email protected]>

* Param passing prototype: Modify action (#577)

* tinyxml2 to string helper

Signed-off-by: Jenn Nguyen <[email protected]>

* add action

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed codecheck errors

Signed-off-by: Jenn Nguyen <[email protected]>

* changed parser_private functions to nonstatic

Signed-off-by: Jenn Nguyen <[email protected]>

* removed specification check

Signed-off-by: Jenn Nguyen <[email protected]>

* remove action

Signed-off-by: Jenn Nguyen <[email protected]>

* add action requires 'name' attribute in spec

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed nested include test

Signed-off-by: Jenn Nguyen <[email protected]>

* removed unused param

Signed-off-by: Jenn Nguyen <[email protected]>

* check name attr nonempty

Signed-off-by: Jenn Nguyen <[email protected]>

* replace action

Signed-off-by: Jenn Nguyen <[email protected]>

* modify action

Signed-off-by: Jenn Nguyen <[email protected]>

* code cleanup

Signed-off-by: Jenn Nguyen <[email protected]>

* added nested model test

Signed-off-by: Jenn Nguyen <[email protected]>

* readXml wrapper

Signed-off-by: Jenn Nguyen <[email protected]>

* SDFPtr to ElementPtr

Signed-off-by: Jenn Nguyen <[email protected]>

* updated test paths

Signed-off-by: Jenn Nguyen <[email protected]>

* removed nested links

Signed-off-by: Jenn Nguyen <[email protected]>

* fixed add & modify bugs

Signed-off-by: Jenn Nguyen <[email protected]>

Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@jennuine jennuine requested a review from azeey July 13, 2021 23:18
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jul 13, 2021
@jennuine jennuine merged commit 722b92c into sdf11 Jul 14, 2021
@jennuine jennuine deleted the jennuine/10_to_11 branch July 14, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants