Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Force Torque Noise functions + Unit tests #669

Merged
merged 8 commits into from
Sep 21, 2021
Merged

Added Force Torque Noise functions + Unit tests #669

merged 8 commits into from
Sep 21, 2021

Conversation

chawladevansh
Copy link

@chawladevansh chawladevansh commented Aug 16, 2021 •
edited
Loading

Signed-off-by: Devansh [email protected]

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

🎉 New feature

Closes #

Summary

Added Force and Torque Noise functions to the FT sdf parser.

Test it

Make and run UNIT_ForceTorqueTest.cc

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Aug 16, 2021
@chapulina chapulina mentioned this pull request Sep 13, 2021
Closed
@mjcarroll mjcarroll marked this pull request as ready for review September 14, 2021 20:20
@mjcarroll mjcarroll changed the base branch from sdf11 to main September 15, 2021 20:27
azeey
azeey reviewed Sep 15, 2021
View reviewed changes
src/ForceTorque.cc Outdated Show resolved Hide resolved
include/sdf/ForceTorque.hh Outdated Show resolved Hide resolved
src/ForceTorque_TEST.cc Show resolved Hide resolved
@mjcarroll
Update forcetorque.sdf
eb37f8b 
Signed-off-by: Michael Carroll <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021 •
edited
Loading

Codecov Report

Merging #669 (6bfff87) into main (4449749) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 6bfff87 differs from pull request most recent head 450ddb0. Consider uploading reports for the commit 450ddb0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
+ Coverage   88.14%   88.19%   +0.05%     
==========================================
  Files          75       75              
  Lines       11363    11414      +51     
==========================================
+ Hits        10016    10067      +51     
  Misses       1347     1347
Impacted Files Coverage Δ
src/ForceTorque.cc 87.75% <100.00%> (+13.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4449749...450ddb0. Read the comment docs.

@chapulina chapulina added beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress and removed 🏢 edifice Ignition Edifice labels Sep 20, 2021
azeey
azeey reviewed Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, otherwise LGTM!

src/ForceTorque.cc Outdated Show resolved Hide resolved
@mjcarroll
Capture nested errors
450ddb0 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll merged commit dfe520d into main Sep 21, 2021
@mjcarroll mjcarroll deleted the force_torque branch September 21, 2021 19:35
@azeey azeey mentioned this pull request Oct 14, 2021
Merged
azeey pushed a commit to azeey/sdformat that referenced this pull request Oct 27, 2021
@mjcarroll @scpeters @azeey
Added Force Torque Noise functions + Unit tests (gazebosim#669)
ce47802 
* Added Force Torque Noise functions + Unit tests

Signed-off-by: Devansh <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
azeey pushed a commit that referenced this pull request Oct 28, 2021
@mjcarroll @scpeters @azeey
Added Force Torque Noise functions + Unit tests (#669)
209eba9 
* Added Force Torque Noise functions + Unit tests

Signed-off-by: Devansh <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
Co-authored-by: Steve Peters <[email protected]>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chawladevansh @codecov-commenter @osrf-triage @azeey @mjcarroll @scpeters @chapulina