Fix world-complete.sdf and add particle_scatter_ratio to v1.8 #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FirefoxMetzger <[email protected]>
FirefoxMetzger
force-pushed
the
fix-world-complete
branch
from
0d882f3 to
9f8a65d
Compare
Codecov Report
@@ Coverage Diff @@
## sdf11 #695 +/- ##
=======================================
Coverage 88.08% 88.08%
=======================================
Files 73 73
Lines 11023 11023
=======================================
Hits 9710 9710
Misses 1313 1313 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #670
As discussed in #670 this PR bumps the SDF version of the test to 1.8 to allow using the //light/intensity element. It also adds the //particle_emitter/particle_scatter_ratio to v1.8 which appears to have been forgotten in the forward port.
Note to maintainers: Remember to use Squash-Merge