Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashton Larkin [email protected]
🎉 New feature
Summary
This builds on top of #736 to add the functionality for converting SDF to USD (this is similar to #762, but #762 is a standalone PR that targets
sdf12
instead of building on #736 - I've been having linking issues with the build, so I am trying to see if building on top of #763 will help solve these issues or not).This PR uses #736 BEFORE CGAL was added, because #736 uses CGAL version 5, which requires ubuntu focal if you want to use the binaries (ubuntu bionic uses CGAL 4). So, to make this PR compatible with bionic and focal, it builds off of the last commit in #736 before CGAL was added: 163637a.
Test it
Like #762, there are linking errors with the tests at the moment, so you can build without tests (use
-DBUILD_TESTING=OFF
when invokingcmake
). I also see a build error which seems to be related to #736:There's also linking errors for the
usdConverter
executable:Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge