Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Add & Clear function to World, Model, and Link #765

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Dec 1, 2021

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

Add functions that allow adding SDF elements to World, Model, and Link DOM objects.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@github-actions github-actions bot added 🌱 garden Ignition Garden 🏯 fortress Ignition Fortress labels Dec 1, 2021
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo nit, LGTM

include/sdf/Model.hh Outdated Show resolved Hide resolved
Signed-off-by: Nate Koenig <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #765 (1d67954) into sdf12 (b95f44d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf12     #765      +/-   ##
==========================================
+ Coverage   89.15%   89.23%   +0.08%     
==========================================
  Files          76       76              
  Lines       12001    12081      +80     
==========================================
+ Hits        10700    10781      +81     
+ Misses       1301     1300       -1     
Impacted Files Coverage Δ
src/Link.cc 97.16% <100.00%> (+0.50%) ⬆️
src/Model.cc 90.31% <100.00%> (+0.78%) ⬆️
src/World.cc 93.73% <100.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95f44d...1d67954. Read the comment docs.

@nkoenig nkoenig merged commit 8707d41 into sdf12 Dec 1, 2021
@nkoenig nkoenig deleted the add_clear_functions branch December 1, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress 🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants