Added plugin to SDF DOM #788
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf12 #788 +/- ##
==========================================
+ Coverage 89.56% 89.60% +0.04%
==========================================
Files 76 78 +2
Lines 12603 12691 +88
==========================================
+ Hits 11288 11372 +84
- Misses 1315 1319 +4
Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
| /// \brief Copy constructor. This is here so that we can copy the | ||
| /// plugin contents. | ||
| /// \param[in] _plugin Plugin to copy. | ||
| public: Plugin(const Plugin &_plugin); |
There was a problem hiding this comment.
We'll need to add move constructor and move assignment as well per the rule of five.
There was a problem hiding this comment.
was there a reason we didn't use ImplPtr here?
There was a problem hiding this comment.
is it because we need to take care to clone the sdf::ElementPtr contents instead of just copying the shared pointer?
There was a problem hiding this comment.
Yes. Here's more context: https://github.com/ignitionrobotics/sdformat/pull/788/files#r770912499
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
|
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Signed-off-by: Nate Koenig [email protected]
🎉 New feature
Summary
Added a
Pluginobject to the SDF DOM and utilized thePluginin the GUI DOM object. I'll addPlugincapabilities to the other DOM objects in future PRs.Test it
Run the tests.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge