Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added non-const mutable accessors for world child objects #840

Merged
merged 11 commits into from
Feb 18, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Feb 2, 2022

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

Similar to #838. This adds non-const accessors to the World class.

Test it

Run the tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Feb 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #840 (cd5ce9c) into sdf12 (424ef80) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            sdf12     #840      +/-   ##
==========================================
+ Coverage   90.87%   90.88%   +0.01%     
==========================================
  Files          78       78              
  Lines       12607    12627      +20     
==========================================
+ Hits        11456    11476      +20     
  Misses       1151     1151              
Impacted Files Coverage Δ
src/World.cc 94.84% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424ef80...cd5ce9c. Read the comment docs.

Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my comment in the other PR, did you leave out mutable World::Frame intentionally?

Otherwise, LGTM!

@nkoenig
Copy link
Contributor Author

nkoenig commented Feb 17, 2022

Added Frame modifiers in 4affb5e

@nkoenig nkoenig requested a review from azeey February 17, 2022 20:33
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple minor comments

include/sdf/World.hh Outdated Show resolved Hide resolved
src/World_TEST.cc Outdated Show resolved Hide resolved
Nate Koenig added 3 commits February 18, 2022 11:11
@nkoenig nkoenig enabled auto-merge (squash) February 18, 2022 20:15
@nkoenig nkoenig merged commit 8a01ee8 into sdf12 Feb 18, 2022
@nkoenig nkoenig deleted the world_mutable_accessors branch February 18, 2022 21:20
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants