-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added non-const mutable accessors for world child objects #840
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf12 #840 +/- ##
==========================================
+ Coverage 90.87% 90.88% +0.01%
==========================================
Files 78 78
Lines 12607 12627 +20
==========================================
+ Hits 11456 11476 +20
Misses 1151 1151
Continue to review full report at Codecov.
|
Signed-off-by: Nate Koenig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my comment in the other PR, did you leave out mutable World::Frame
intentionally?
Otherwise, LGTM!
Signed-off-by: Nate Koenig <[email protected]>
Added Frame modifiers in 4affb5e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple minor comments
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1 |
Signed-off-by: Nate Koenig [email protected]
🎉 New feature
Summary
Similar to #838. This adds non-const accessors to the World class.
Test it
Run the tests
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.