Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to utils version of env functions #854

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Switch to utils version of env functions #854

merged 3 commits into from
Feb 21, 2022

Conversation

mjcarroll
Copy link
Contributor

Since we depend on utils, we can use the functionality from there.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Feb 18, 2022
@mjcarroll mjcarroll self-assigned this Feb 18, 2022
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the CI failures should be fixed by #847, but the Console_TEST failures come from this PR. My guess is it's the difference between GetEnvironmentVariable and getenv_s in Windows.

test/env.hh Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2022

Codecov Report

Merging #854 (e6aa455) into main (54188ff) will increase coverage by 0.19%.
The diff coverage is 99.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   90.69%   90.88%   +0.19%     
==========================================
  Files          78       78              
  Lines       12433    12629     +196     
==========================================
+ Hits        11276    11478     +202     
+ Misses       1157     1151       -6     
Impacted Files Coverage Δ
include/sdf/InterfaceElements.hh 75.00% <ø> (+25.00%) ⬆️
src/Utils.hh 94.73% <ø> (ø)
src/Utils.cc 83.57% <88.88%> (+0.36%) ⬆️
src/Console.cc 87.93% <100.00%> (+0.21%) ⬆️
src/FrameSemantics.cc 84.41% <100.00%> (+1.39%) ⬆️
src/InterfaceElements.cc 100.00% <100.00%> (ø)
src/InterfaceModel.cc 100.00% <100.00%> (ø)
src/Link.cc 98.53% <100.00%> (+0.90%) ⬆️
src/Model.cc 92.45% <100.00%> (+0.99%) ⬆️
src/ParserConfig.cc 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce7061...e6aa455. Read the comment docs.

@mjcarroll mjcarroll merged commit c2ef096 into main Feb 21, 2022
@mjcarroll mjcarroll deleted the remove_custom_env branch February 21, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants