Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USD -> SDF: Added cmd line tool #862

Merged
merged 2 commits into from
Mar 10, 2022
Merged

USD -> SDF: Added cmd line tool #862

merged 2 commits into from
Mar 10, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Feb 25, 2022

🎉 New feature

Summary

This PR builds on top of this other PR #827. It adds the cmd line tool usd2sdf.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from adlarkin February 25, 2022 12:49
@ahcorde ahcorde self-assigned this Feb 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #862 (0595369) into ahcorde/usd_to_sdf_initial_commit (4c4f311) will decrease coverage by 0.01%.
The diff coverage is 76.19%.

❗ Current head 0595369 differs from pull request most recent head 36ad5ff. Consider uploading reports for the commit 36ad5ff to get more accurate results

Impacted file tree graph

@@                          Coverage Diff                          @@
##           ahcorde/usd_to_sdf_initial_commit     #862      +/-   ##
=====================================================================
- Coverage                              88.40%   88.38%   -0.02%     
=====================================================================
  Files                                     93       94       +1     
  Lines                                  13970    13991      +21     
=====================================================================
+ Hits                                   12350    12366      +16     
- Misses                                  1620     1625       +5     
Impacted Files Coverage Δ
usd/src/cmd/usd2sdf.cc 76.19% <76.19%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c4f311...36ad5ff. Read the comment docs.

@ahcorde ahcorde added the usd label Feb 25, 2022
@adlarkin adlarkin force-pushed the ahcorde/usd_to_sdf_initial_commit branch 2 times, most recently from 3ae7fd9 to 6ada66f Compare March 8, 2022 22:51
Base automatically changed from ahcorde/usd_to_sdf_initial_commit to sdf12 March 9, 2022 11:42
@ahcorde ahcorde force-pushed the ahcorde/usd_to_sdf_cmd branch from d916dc5 to 48c499b Compare March 9, 2022 12:22
Signed-off-by: Ashton Larkin <[email protected]>
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few minor changes in fb478e7. LGTM!

@ahcorde
Copy link
Collaborator Author

ahcorde commented Mar 9, 2022

@osrf-jenkins retest this please

@ahcorde ahcorde merged commit b7447df into sdf12 Mar 10, 2022
@ahcorde ahcorde deleted the ahcorde/usd_to_sdf_cmd branch March 10, 2022 08:59
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants