USD to SDF: Added links #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
… ahcorde/usd_to_sdf_transforms
Signed-off-by: ahcorde <[email protected]>
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <[email protected]>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <[email protected]>
… ahcorde/usd_to_sdf_transforms
…nto ahcorde/usd_to_sdf_lights
Signed-off-by: ahcorde <[email protected]>
…ahcorde/usd_to_sdf_links
Signed-off-by: ahcorde <[email protected]>
…ahcorde/usd_to_sdf_links
…ahcorde/usd_to_sdf_links
Signed-off-by: ahcorde <[email protected]>
…nrobotics/sdformat into ahcorde/usd_to_sdf_links
|
@ahcorde it looks like there are merge conflicts with |
|
Done @adlarkin |
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf12 #902 +/- ##
=======================================
Coverage 87.70% 87.70%
=======================================
Files 104 105 +1
Lines 15109 15190 +81
=======================================
+ Hits 13251 13323 +72
- Misses 1858 1867 +9
Continue to review full report at Codecov.
|
Signed-off-by: Ashton Larkin <[email protected]>
adlarkin
reviewed
Apr 7, 2022
Signed-off-by: ahcorde <[email protected]>
|
@adlarkin ready for a final review |
adlarkin
approved these changes
Apr 8, 2022
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Ashton Larkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.