Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ign-common console #928

Closed
wants to merge 3 commits into from
Closed

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Mar 31, 2022

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

This replaces the use of SDF's Console with Ignition's Console logging.

Test it

The tests should all pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested review from azeey and scpeters as code owners March 31, 2022 23:55
Nate Koenig added 2 commits March 31, 2022 16:57
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
@chapulina
Copy link
Contributor

Have you seen the discussion on

Instead of extending our use of common::Console, I think we should be considering to retire it in favor of a dedicated library, such as spdlog, so we can stop maintaining our own logger (this recent time-consuming PR comes to mind).

@chapulina chapulina added the 🌱 garden Ignition Garden label Apr 5, 2022
@nkoenig nkoenig closed this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants