-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Added basic structure #932
Conversation
Signed-off-by: ahcorde <[email protected]>
4e7cf29
to
25cc8a5
Compare
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #932 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 100 100
Lines 14637 14637
=======================================
Hits 12905 12905
Misses 1732 1732 Continue to review full report at Codecov.
|
CMakeLists.txt
Outdated
"Use dist-packages instead of site-package to install python modules" | ||
OFF) | ||
|
||
include(IgnPython) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is already some code to find python up at lines 60-90; we should unify that code with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: ahcorde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set the cmake_minimum_required
version to 3.12 since main
is
targetting focal
and later? This will ensure that we're using find_package(Python3)
in ign-cmake.
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
🎉 New feature
This PR is part of this mete ticket #931
Summary
This PR add the basic structure to create Python binding using pybind11
Test it
Compile the code, export the pythonpath and run the example
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.