Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ParserConfig Python interface #934

Merged
merged 10 commits into from
Apr 6, 2022
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 4, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

This PR is part of this mete ticket #931

Summary

Added ParserConfig Python interface

Test it

from sdformat import ErrParserConfigor

parserConfig = ParserConfig()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 4, 2022
@ahcorde ahcorde requested review from azeey and scpeters as code owners April 4, 2022 20:24
@ahcorde ahcorde self-assigned this Apr 4, 2022
@ahcorde ahcorde mentioned this pull request Apr 4, 2022
62 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #934 (57c294d) into main (6c9b4ad) will decrease coverage by 0.06%.
The diff coverage is 62.50%.

❗ Current head 57c294d differs from pull request most recent head 052ef06. Consider uploading reports for the commit 052ef06 to get more accurate results

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
- Coverage   88.14%   88.07%   -0.07%     
==========================================
  Files         102      103       +1     
  Lines       14706    14746      +40     
==========================================
+ Hits        12962    12987      +25     
- Misses       1744     1759      +15     
Impacted Files Coverage Δ
python/src/sdf/pyParserConfig.cc 61.53% <61.53%> (ø)
python/src/sdf/_ignition_sdformat_pybind11.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9b4ad...052ef06. Read the comment docs.

@chapulina chapulina added 🌱 garden Ignition Garden mujoco labels Apr 5, 2022
Base automatically changed from ahcorde/python/basic_structure to main April 5, 2022 20:34
@azeey
Copy link
Collaborator

azeey commented Apr 6, 2022

Mind resolving the conflicts?

@ahcorde
Copy link
Collaborator Author

ahcorde commented Apr 6, 2022

Done @azeey

python/src/sdf/pyParserConfig.cc Outdated Show resolved Hide resolved
python/src/sdf/pyParserConfig.cc Outdated Show resolved Hide resolved
python/src/sdf/pyParserConfig.cc Outdated Show resolved Hide resolved
python/src/sdf/pyParserConfig.cc Outdated Show resolved Hide resolved
python/test/pyParserConfig_TEST.py Outdated Show resolved Hide resolved
python/test/pyParserConfig_TEST.py Show resolved Hide resolved
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde requested a review from azeey April 6, 2022 16:48
python/src/sdf/pyParserConfig.cc Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde enabled auto-merge (squash) April 6, 2022 17:13
@ahcorde ahcorde merged commit 96ab662 into main Apr 6, 2022
@ahcorde ahcorde deleted the ahcorde/python/parserconfig branch April 6, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants