Added --inertial-stats option to ign sdf
#936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
adityapande-1995
force-pushed
the
aditya/inertial_stats
branch
from
1d5686f to
492a436
Compare
Signed-off-by: Aditya <[email protected]>
scpeters
reviewed
Apr 6, 2022
scpeters
reviewed
Apr 6, 2022
Codecov Report
@@ Coverage Diff @@
## sdf12 #936 +/- ##
==========================================
+ Coverage 87.68% 87.70% +0.01%
==========================================
Files 104 104
Lines 15049 15109 +60
==========================================
+ Hits 13196 13251 +55
- Misses 1853 1858 +5
Continue to review full report at Codecov.
|
Signed-off-by: Aditya <[email protected]>
jennuine
reviewed
Apr 7, 2022
… does not have a world Signed-off-by: Aditya <[email protected]>
scpeters
reviewed
Apr 7, 2022
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
Signed-off-by: Aditya <[email protected]>
scpeters
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
I tested this with the VIPER urdf, and it failed to load with libsdformat12 due to #746, so we should prioritize fixing that issue as well, but that is not the fault of this PR. We should also backport this to libsdformat9 so it will be available to gazebo11 users.
looks good
adityapande-1995
added a commit
that referenced
this pull request
Apr 8, 2022
Signed-off-by: Aditya <[email protected]>
8 tasks
scpeters
pushed a commit
that referenced
this pull request
Apr 11, 2022
* Ported changes from #936 * Removed quick return logic Signed-off-by: Aditya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya [email protected]
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Closes #832
Summary
Adds an option of
--inertial-statstoign sdftool and prints out centre of mass, total mass, and moment of inertia matrix of the given model sdf.Test it
Working on a test case.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸