Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Box python interface #937

Merged
merged 5 commits into from
Apr 7, 2022
Merged

Added Box python interface #937

merged 5 commits into from
Apr 7, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 6, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

This PR is part of this mete ticket #931

Summary

Added Box Python interface

Test it

from sdformat import Box

box = Box()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 6, 2022
@ahcorde ahcorde requested review from azeey and scpeters as code owners April 6, 2022 08:58
@ahcorde ahcorde self-assigned this Apr 6, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 6, 2022
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde mentioned this pull request Apr 6, 2022
62 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #937 (aeb9f3b) into main (96ab662) will decrease coverage by 0.01%.
The diff coverage is 68.42%.

❗ Current head aeb9f3b differs from pull request most recent head ece62d7. Consider uploading reports for the commit ece62d7 to get more accurate results

@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   88.07%   88.06%   -0.02%     
==========================================
  Files         103      104       +1     
  Lines       14744    14765      +21     
==========================================
+ Hits        12986    13003      +17     
- Misses       1758     1762       +4     
Impacted Files Coverage Δ
python/src/sdf/pyBox.cc 66.66% <66.66%> (ø)
python/src/sdf/_ignition_sdformat_pybind11.cc 100.00% <100.00%> (ø)
src/Box.cc 97.22% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ab662...ece62d7. Read the comment docs.

@ahcorde ahcorde mentioned this pull request Apr 6, 2022
8 tasks
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment about the test.

python/test/pyBox_TEST.py Outdated Show resolved Hide resolved
@ahcorde ahcorde enabled auto-merge (squash) April 7, 2022 07:59
@ahcorde ahcorde merged commit f87b2ef into main Apr 7, 2022
@ahcorde ahcorde deleted the ahcorde/python/box branch April 7, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants