Added Atmosphere Python interface #968
Conversation
Signed-off-by: Alejandro Hernández <[email protected]>
Signed-off-by: Alejandro Hernández <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 27 27
=======================================
Hits 18 18
Misses 9 9 Continue to review full report at Codecov.
|
python/src/sdf/pyAtmosphere.cc
Outdated
| return sdf::Atmosphere(self); | ||
| }, "memo"_a); | ||
|
|
||
| pybind11::enum_<sdf::AtmosphereType>(geometryModule, "AtmosphereType") |
There was a problem hiding this comment.
Should this be in the sdformat namespace?
There was a problem hiding this comment.
you should access this enum:
Atmosphere.AtmosphereType.ADIABATICThere was a problem hiding this comment.
Right, but that is different from the C++ equivalent sdf::AtmosphereType where it's directly under sdf, not sdf::Atmosphere::AtmosphereType. I'm just asking if we should try to closely match the C++ API or not.
There was a problem hiding this comment.
for now, I'm using this way with all the python bindings, we can make a decision at the end and change all of them at once.
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 27 27
=======================================
Hits 18 18
Misses 9 9 Continue to review full report at Codecov.
|
Signed-off-by: ahcorde [email protected]
🎉 New feature
This PR is part of this mete ticket #931
Summary
Added Atmosphere Python interface
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.