Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Magnetometer Python interface #972

Merged
merged 8 commits into from
May 23, 2022
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 12, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

This PR is part of this mete ticket #931

Require

Summary

Added interface Python interface

Test it

from sdformat import interface

magnetometer = interface()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández <[email protected]>
@ahcorde ahcorde added the scripting Scripting interfaces to Ignition label Apr 12, 2022
@ahcorde ahcorde self-assigned this Apr 12, 2022
@ahcorde ahcorde mentioned this pull request Apr 12, 2022
62 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 12, 2022
Signed-off-by: Alejandro Hernández <[email protected]>
@ahcorde ahcorde mentioned this pull request Apr 18, 2022
8 tasks
@ahcorde ahcorde marked this pull request as ready for review April 19, 2022 15:40
@ahcorde ahcorde requested review from azeey and scpeters as code owners April 19, 2022 15:40
Signed-off-by: ahcorde <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #972 (1864a74) into main (7baa3ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7baa3ee...1864a74. Read the comment docs.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #972 (34277ef) into main (ffdc7cd) will not change coverage.
The diff coverage is n/a.

❗ Current head 34277ef differs from pull request most recent head 891453c. Consider uploading reports for the commit 891453c to get more accurate results

@@           Coverage Diff           @@
##             main     #972   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5276b8...891453c. Read the comment docs.

Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment.

python/test/pyMagnetometer_TEST.py Show resolved Hide resolved
@ahcorde ahcorde merged commit ec2b85b into main May 23, 2022
@ahcorde ahcorde deleted the ahcorde/python/magnetometer branch May 23, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants