-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Physics Python interface #995
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #995 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 27 27
=======================================
Hits 18 18
Misses 9 9 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 83.23% 83.16% -0.08%
==========================================
Files 152 153 +1
Lines 18594 18648 +54
==========================================
+ Hits 15477 15508 +31
- Misses 3117 3140 +23
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Missing one member function, I think.
Signed-off-by: ahcorde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one minor comment
python/test/pyWorld_TEST.py
Outdated
# self.assertTrue(world.Scene().OriginVisual()) | ||
# } | ||
|
||
def test_set_scene(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def test_set_scene(self): | |
def test_set_physics(self): |
Signed-off-by: ahcorde <[email protected]>
|
Signed-off-by: ahcorde [email protected]
🎉 New feature
This PR is part of this mete ticket #931
Summary
Added Physics Python interface
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.