Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Physics Python interface #995

Merged
merged 15 commits into from
Jun 29, 2022
Merged

Added Physics Python interface #995

merged 15 commits into from
Jun 29, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 20, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

This PR is part of this mete ticket #931

Summary

Added Physics Python interface

Test it

from sdformat import Physics

physics = Physics()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde added scripting Scripting interfaces to Ignition mujoco labels Apr 20, 2022
@ahcorde ahcorde requested review from azeey and scpeters as code owners April 20, 2022 18:20
@ahcorde ahcorde self-assigned this Apr 20, 2022
@ahcorde ahcorde mentioned this pull request Apr 20, 2022
62 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #995 (9d830bb) into main (bb84733) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #995   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb84733...9d830bb. Read the comment docs.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #995 (c9e20c3) into main (50032e9) will decrease coverage by 0.07%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   83.23%   83.16%   -0.08%     
==========================================
  Files         152      153       +1     
  Lines       18594    18648      +54     
==========================================
+ Hits        15477    15508      +31     
- Misses       3117     3140      +23     
Impacted Files Coverage Δ
python/src/sdf/pyWorld.cc 53.21% <44.44%> (-1.74%) ⬇️
python/src/sdf/pyPhysics.cc 60.00% <60.00%> (ø)
python/src/sdf/_ignition_sdformat_pybind11.cc 100.00% <100.00%> (ø)
src/World.cc 95.27% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50032e9...c9e20c3. Read the comment docs.

Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Missing one member function, I think.

python/src/sdf/pyWorld.cc Show resolved Hide resolved
@ahcorde ahcorde requested a review from azeey June 28, 2022 21:43
Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment

# self.assertTrue(world.Scene().OriginVisual())
# }

def test_set_scene(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_set_scene(self):
def test_set_physics(self):

@azeey
Copy link
Collaborator

azeey commented Jun 29, 2022

pyWorld_TEST is failing. And it looks like Jenkins is not capturing test failures from python tests. There are a bunch of failures on homebrew, but the test results shows 0 failures. Is this a known issue?

@ahcorde ahcorde merged commit b98fc4b into main Jun 29, 2022
@ahcorde ahcorde deleted the ahcorde/python/physics branch June 29, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants