Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sky Python interface #996

Merged
merged 7 commits into from
Jun 9, 2022
Merged

Added Sky Python interface #996

merged 7 commits into from
Jun 9, 2022

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 20, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

This PR is part of this meta ticket #931

Summary

Added Sky Python interface

Test it

from sdformat import Sky

sky = Sky()

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde added scripting Scripting interfaces to Ignition mujoco labels Apr 20, 2022
@ahcorde ahcorde requested review from azeey and scpeters as code owners April 20, 2022 18:56
@ahcorde ahcorde self-assigned this Apr 20, 2022
@ahcorde ahcorde mentioned this pull request Apr 20, 2022
62 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 20, 2022
ahcorde added 2 commits April 20, 2022 21:42
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #996 (043c9ee) into main (bb84733) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files           2        2           
  Lines          27       27           
=======================================
  Hits           18       18           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb84733...043c9ee. Read the comment docs.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #996 (531e683) into main (a92a354) will increase coverage by 16.80%.
The diff coverage is 77.16%.

@@             Coverage Diff             @@
##             main     #996       +/-   ##
===========================================
+ Coverage   66.66%   83.47%   +16.80%     
===========================================
  Files           2      148      +146     
  Lines          27    18393    +18366     
===========================================
+ Hits           18    15353    +15335     
- Misses          9     3040     +3031     
Impacted Files Coverage Δ
include/sdf/InterfaceElements.hh 75.00% <ø> (ø)
include/sdf/Param.hh 83.75% <ø> (ø)
include/sdf/Types.hh 100.00% <ø> (ø)
python/src/sdf/pyAtmosphere.cc 60.00% <ø> (ø)
python/src/sdf/pyPlane.cc 72.72% <ø> (ø)
python/src/sdf/pySemanticPose.cc 72.22% <ø> (ø)
src/SDFExtension.hh 100.00% <ø> (ø)
src/Utils.hh 94.73% <ø> (ø)
usd/src/cmd/usd2sdf.cc 86.66% <ø> (ø)
usd/src/sdf_parser/World.cc 83.33% <ø> (ø)
... and 242 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094e7a2...531e683. Read the comment docs.

@scpeters scpeters merged commit e91782b into main Jun 9, 2022
@scpeters scpeters deleted the ahcorde/python/sky branch June 9, 2022 17:58
methylDragon pushed a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden mujoco scripting Scripting interfaces to Ignition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants