Added Plugin Python interface #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <[email protected]>
62 tasks
Codecov Report
@@ Coverage Diff @@
## main #997 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 2 2
Lines 27 27
=======================================
Hits 18 18
Misses 9 9 Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
azeey
reviewed
May 26, 2022
…orde/python/plugin
9 tasks
Signed-off-by: ahcorde <[email protected]>
azeey
approved these changes
May 31, 2022
include/sdf/Root.hh
Outdated
| /// \param[out] _worldName The name of the world | ||
| /// \return Errors, which is a vector of Error objects. Each Error includes | ||
| /// an error code and message. An empty vector indicates no error. | ||
| public: Errors WorldName(const std::string &_filename, |
There was a problem hiding this comment.
I think this is from a different PR :)
src/Root.cc
Outdated
| @@ -140,6 +140,40 @@ Root::Root() | |||
| { | |||
| } | |||
|
|
|||
| Errors Root::WorldName(const std::string &_filename, std::string &_worldName) | |||
src/Root_TEST.cc
Outdated
| @@ -65,6 +66,24 @@ TEST(DOMRoot, MoveAssignmentOperator) | |||
| EXPECT_EQ("test_root", root2.Version()); | |||
| } | |||
|
|
|||
| TEST(DOMRoot, WorldName) | |||
Signed-off-by: ahcorde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde [email protected]
🎉 New feature
This PR is part of this meta ticket #931
Summary
Added Plugin Python interface
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.