Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : API 리팩토링 완료 #14

Merged
merged 1 commit into from
Nov 17, 2023
Merged

feat : API 리팩토링 완료 #14

merged 1 commit into from
Nov 17, 2023

Conversation

oxdjww
Copy link
Member

@oxdjww oxdjww commented Nov 15, 2023

Agent-Server api

Front-Server api

구현 했습니다.. 성능 생각 안 하고 돌아가게만 일단 구현 했습니다.. 리뷰 해주세요..

Copy link
Contributor

@Sharp0802 Sharp0802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested ACK

@router.get("/tmp/{filename}")
def get_agent_tmp_data(filename: str):
# 샘플 데이터 반환 (log_data.json, pod_data.json, traffic_data.json)
with open("tmp/{filename}.json", "r") as json_file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

취약점입니다
나중에 수정해주세요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

취약점입니다 나중에 수정해주세요

ACK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사용자 input에 대한 검증없이 read를 하게되면 파일 트래버서링등의 웹해킹을 당할 수 있어요:)

Copy link
Contributor

@limjung99 limjung99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@limjung99 limjung99 merged commit dbacea3 into master Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants