whisper: fix issue in topic list copy

Fixes ethereum#16271. What was appeneded was a pointer to an object that changes during the iteration.
gballet · Mar 26, 2018 · fd8a278 · fd8a278
1 parent 85ea915
commit fd8a278
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/whisper/whisperv6/api.go b/whisper/whisperv6/api.go
@@ -558,9 +558,10 @@ func (api *PublicWhisperAPI) NewMessageFilter(req Criteria) (string, error) {
 	}
 
 	if len(req.Topics) > 0 {
-		topics = make([][]byte, 0, len(req.Topics))
-		for _, topic := range req.Topics {
-			topics = append(topics, topic[:])
+		topics = make([][]byte, len(req.Topics))
+		for i, topic := range req.Topics {
+			topics = append(topics, make([]byte, 0, len(topic)))
+			copy(topics[i], topic[:])
 		}
 	}