move the overlay transition to Finalize #309
Closed
+14
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a review with Gary. we came to the conclusion that the overlay transition should be moved to finalize for the moment. This isn't as easy at it looks, because we need to ensure that the transition is activated before the fork block is executed. But the overlay copy itself could be done in prepare or Finalize.
This works fine on kaustinen since the transition is done at genesis time and doesn't use that function. But in order to go further, this needs to be tested with a post-genesis transition.