Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add actix-web support #24

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: add actix-web support #24

wants to merge 5 commits into from

Conversation

gbaranski
Copy link
Owner

closes #22

@gbaranski gbaranski force-pushed the feat/add-actix-web branch from a2b8be8 to a2c3e66 Compare March 5, 2023 22:31
@gbaranski
Copy link
Owner Author

gbaranski commented Mar 5, 2023

https://github.com/gbaranski/ezsockets/pull/24/files#diff-af2ac423df8a6040ceaff3261918db8272e6b8b374297fcf9776bea2c73adbbfR106-R114

I am having a problem constructing a stream that satisfies AsyncRead + AsyncWrite + Unpin in order to pass it to tokio_tungstenite::WebSocketStream::from_raw_socket.

Everything else related to ezsockets is done few lines below, with mocked WebSocketStream.

@LucaCappelletti94
Copy link

Hi! How is this going? Need any help?

@gbaranski
Copy link
Owner Author

Hi! How is this going? Need any help?

Hey!
I recently don't have much time to work on ezsockets, so any contribution would be greatly appreciated :D.

@LucaCappelletti94
Copy link

I can look into it, but could you briefly describe the state of things? What needs to be done?

@gbaranski
Copy link
Owner Author

gbaranski commented Mar 5, 2024

I can look into it, but could you briefly describe the state of things? What needs to be done?

Well, I had some problems adapting our Socket interfaces to Actix interfaces, that's quite troublesome due to the complexity of the whole Actix ecosystem.

I am not aware of recent changes of Actix, so it might be needed to start over from the beginning, in order to fully understand how does it work.

The current state is that I was not able to create an actual stream. See my previous comment: #24 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add actix-web integration
2 participants