Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor i18n and breadcrumb fixes #688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamchaboryk
Copy link

Do not delete the following line

@netlify /en/pages-to-review/

(Pick the language of your choice to fill out the following information.)

What does this pull request (PR) do?

Very small PR, I noticed these issues while working on my Sa11y PR. Last PR for now! Cheers!

Fixes a localization issue with the header logo

Before:

<a href="https://www.canada.ca/en.html" property="url">
            <img src="https://www.canada.ca/etc/designs/canada//wet-boew/assets/sig-blk-en.svg" alt="Government of Canada" property="logo">
            <span class="wb-inv"> / <span lang="fr">Government of Canada</span></span>
          </a>

After (English):

<a href="https://www.canada.ca/en.html" property="url">
            <img src="https://www.canada.ca/etc/designs/canada//wet-boew/assets/sig-blk-en.svg" alt="Government of Canada" property="logo">
            <span class="wb-inv"> / <span lang="fr">Gouvernement du Canada</span></span>
          </a>

After (French):

<a href="https://www.canada.ca/fr.html" property="url">
            <img src="https://www.canada.ca/etc/designs/canada//wet-boew/assets/sig-blk-fr.svg" alt="Gouvernement du Canada" property="logo">
            <span class="wb-inv"> / <span lang="en">Government of Canada</span></span>
          </a>

Fixes a localization issue with the footer logo

The Symbol of Canada logo's alt text was hard coded as English in the NJK file. It now displays proper translation.

Fixes a breadcrumb issue on homepage

A breadcrumb link gets automatically generated on the homepage that has no discernible text.

Resolves this issue:

Screenshot of error stating that the link does not have discernible text that is visible to screen readers and other assistive technology.

Copy link

netlify bot commented Feb 15, 2025

Deploy Preview for a11ycanada ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f6a3ad1
🔍 Latest deploy log https://app.netlify.com/sites/a11ycanada/deploys/67b0cb71188dd4000861db32
😎 Deploy Preview https://deploy-preview-688--a11ycanada.netlify.app/en/pages-to-review/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant